seam: eslint.config.js has no ignore for the generated OpenAPI client #79

New issue

Closed

opened 2026-09-11 13:23:00 +00:00 by bart · 1 comment

bart commented

2026-09-11 13:23:00 +00:00

Collaborator

frontend/eslint.config.js (frontend root, not owned by any feature track) has no ignores entry for src/app/core/api/generated/**. That directory is produced by npm run api:gen from the committed backend/openapi.json (docs/12-implementation-plan.md: "the generated output (core/api/generated/) is git-ignored and produced on npm ci/CI, so only the spec is versioned").

Now that backend/openapi.json has a real, populated API surface (PH1.7 merged), running npm run api:gen && ng lint produces ~210 @typescript-eslint/consistent-indexed-object-style errors inside the generated schema.d.ts file itself — nothing in application code. This will hit every future frontend PR that imports components['schemas'][...] from the generated client (i.e. most of them from here on), and presumably CI's eslint step in the PH0.6 pipeline once it runs api:gen before linting.

Fix: add an ignores: ['src/app/core/api/generated/**'] entry (global ignore, or scoped to the **/*.ts block) to frontend/eslint.config.js.

Found while building #16 (T-A frontend): all frontend/src/app/features/** code lints clean on its own; the generated file is the only source of ng lint failures. Filing as a seam request per CLAUDE.md ("don't touch files outside owned paths") rather than widening #16 or editing a file that pre-existed my session.

`frontend/eslint.config.js` (frontend root, not owned by any feature track) has no `ignores` entry for `src/app/core/api/generated/**`. That directory is produced by `npm run api:gen` from the committed `backend/openapi.json` (docs/12-implementation-plan.md: "the generated output (core/api/generated/) is git-ignored and produced on npm ci/CI, so only the spec is versioned"). Now that `backend/openapi.json` has a real, populated API surface (PH1.7 merged), running `npm run api:gen && ng lint` produces ~210 `@typescript-eslint/consistent-indexed-object-style` errors inside the generated `schema.d.ts` file itself — nothing in application code. This will hit every future frontend PR that imports `components['schemas'][...]` from the generated client (i.e. most of them from here on), and presumably CI's `eslint` step in the PH0.6 pipeline once it runs `api:gen` before linting. **Fix**: add an `ignores: ['src/app/core/api/generated/**']` entry (global ignore, or scoped to the `**/*.ts` block) to `frontend/eslint.config.js`. Found while building #16 (T-A frontend): all `frontend/src/app/features/**` code lints clean on its own; the generated file is the only source of `ng lint` failures. Filing as a seam request per CLAUDE.md ("don't touch files outside owned paths") rather than widening #16 or editing a file that pre-existed my session.

bart referenced this issue

2026-09-11 13:23:26 +00:00

T-A — Master data & catalogue: domain services, routers and pages P05–P08, P11 #16

bart referenced this issue from a commit

2026-09-11 13:27:06 +00:00

fix(web): lint and production-build fixes across P05-P08/P11 pages

bart referenced this issue

2026-09-11 13:27:42 +00:00

feat(web): master-data pages for jobs, vehicles, sites, crews and catalogue (P05-P08, P11) #83

bart commented

2026-09-11 13:28:11 +00:00

Author

Collaborator

Already fixed — PR #77 (issue #44, merged) added exactly this ignores: ['src/app/core/api/generated/**'] entry to eslint.config.js. Confirmed ng lint passes clean on main now. Closing.

Already fixed — PR #77 (issue #44, merged) added exactly this `ignores: ['src/app/core/api/generated/**']` entry to `eslint.config.js`. Confirmed `ng lint` passes clean on `main` now. Closing.

bart closed this issue

2026-09-11 13:28:11 +00:00